Repository navigation
Conversation
|
@copilot we just merged a fix to main that we think might address the CI failures here. Can you look at pulling in the most recent changes to this PR and then checking the CI again? |
There was a problem hiding this comment.
🟡 Changes recommended
The corrected schema and response parsing lack deterministic automated coverage.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Updates DOI creation to match DataCite’s JSON:API structure and httr2 response handling.
Changes:
- Corrects nested metadata arrays in the request payload.
- Reads the DOI from
data.attributes.doi. - Renames the response variable to
resp.
File summaries
| File | Description |
|---|---|
R/newBiocPkgDOI.R |
Updates DataCite request and response structures. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| identifiers = list(list( | ||
| identifier = pkg_doi, | ||
| identifierType = "DOI" | ||
| ), | ||
| creators = list(name = paste(authors, collapse = ", ")), | ||
| titles = list(title = pkg), | ||
| )), | ||
| creators = list(list(name = paste(authors, collapse = ", "))), |
|
Diagnosed the CI failures here: all 4 checks were failing due to pre-existing, unrelated flakiness in the Recreated this change on top of current |
Not sure when the structure changed, but needed to edit the JSON and also rename response to resp to avoid conflict with httr2 function.